[PATCH linux dev-4.10] spi-nor: aspeed-smc: Fix flash window size message

C├ędric Le Goater clg at kaod.org
Thu May 4 22:13:40 AEST 2017


On 05/04/2017 01:52 PM, Andrew Jeffery wrote:
> On Thu, 2017-05-04 at 12:04 +0930, Joel Stanley wrote:
>> When booting we see something like this:
>>
>>  aspeed-smc 1e620000.flash-controller: Using IRQ 17
>>  aspeed-smc 1e620000.flash-controller: DMA support disabled.
>>  aspeed-smc 1e620000.flash-controller: mx25l25635e (32768 Kbytes)
>>  aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000- 0x22000000 ] 32MB
>>  aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000- 0x2a000000 ] 128MB
>>
>> The lack of space after the first hex number haunts me every time I
>> boot a BMC.
>>
>> With this fix we see the pleasingly symmetrical:
>>
>>  aspeed-smc 1e620000.flash-controller: CE0 window [ 0x20000000 - 0x22000000 ] 32MB
>>  aspeed-smc 1e620000.flash-controller: CE1 window [ 0x22000000 - 0x2a000000 ] 128MB
>>
>>> Signed-off-by: Joel Stanley <joel at jms.id.au>
>> ---
>>  drivers/mtd/spi-nor/aspeed-smc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/spi-nor/aspeed-smc.c b/drivers/mtd/spi-nor/aspeed-smc.c
>> index 875b029198fc..23622bf62b6b 100644
>> --- a/drivers/mtd/spi-nor/aspeed-smc.c
>> +++ b/drivers/mtd/spi-nor/aspeed-smc.c
>> @@ -709,7 +709,7 @@ static u32 chip_set_segment(struct aspeed_smc_chip *chip, u32 cs, u32 start,
>>>  		size = end - start;
>>>  	}
>>  
>>> -	dev_info(chip->nor.dev, "CE%d window [ 0x%.8x- 0x%.8x ] %dMB",
>>> +	dev_info(chip->nor.dev, "CE%d window [ 0x%.8x - 0x%.8x ] %dMB",
>>  		 cs, start, end, size >> 20);
> 
> NAK! I want *no* spaces!
> 
> Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

ah ! as you wish, I have no strong feeling on the format :) 

Cheers,

C.



More information about the openbmc mailing list