Switching to 4.10
bradleyb at fuzziesquirrel.com
Tue May 2 00:41:06 AEST 2017
> On May 1, 2017, at 10:33 AM, Matthew Barth <msbarth at linux.vnet.ibm.com> wrote:
> On 04/27/17 8:24 PM, Joel Stanley wrote:
>> On Fri, Apr 28, 2017 at 1:39 AM, Matthew Barth
>> <msbarth at linux.vnet.ibm.com> wrote:
>>> On 04/27/17 2:33 AM, Joel Stanley wrote:
>>>> On Thu, Apr 27, 2017 at 3:00 AM, Rick Altherr <raltherr at google.com> wrote:
>>>>> I saw Joel started https://gerrit.openbmc-project.xyz/#/c/2846/ which has
>>>>> defconfig for ast2400. If you have one for ast2500, please upload a new
>>>>> patch set to that change.
>>>> I have defconfigs in the tree that are ready to go. I will upload them
>>>> to Gerrit when I get the chance.
>>>> I've pulled in:
>>>> - Ben's ftgmac100 patches from the net-next tree
>>>> - Brendan's i2c patches, v7
>>>> - Andrew's GPIO and Pinconf patches from the gpio and pinconf trees
>>>> - Chris Bostic's FSI series, v6
>>>> These are going through a test cycle on the ast2500evb and Plametto
>>>> tonight. Once I have an ack for the i2c device tree, I will add that
>>>> to the tree and push to github.
>>>> Eddie, can you let me know which version of your OCC hwmon patches you
>>>> want included. Same goes for the CFAM I2C patches. If you want to wait
>>>> for review then please ping your reviewers and we can see if we can
>>>> get the patches reviewed before we include them.
>>>> Brad, can you point me to the SBE FIFO work that you want included. If
>>>> you would prefer to wait for review that is okay.
>>>> Matt, I think do you want to merge the MAX31785 hwmon driver as-is for
>>> I thought we already have a MAX31785 driver merged, so what is
>>> 'as-is'...does that include the update supporting reading the tach feedback
>>> from both rotors as described in
>>> issue#652(https://github.com/openbmc/openbmc/issues/652)? The commit you
>>> referenced in that issue does not have the dual tach feedback support yet.
>> No, that driver is not upstream and therefore it is not in the tree.
>> It needs to be included in the OpenBMC tree as part of this work.
>> Thanks for clarifying the issue about dual tach feedback.
>> Is it useful for you to have the driver merged as-is, or does it need
>> to have that feature enabled before you can do any testing?
Sorry Joel, I asked for this to be merged without full understanding. We are already
testing with a driver that supports a single feedback entry. So I’m now confused as
to what you would be merging that we don’t already have in the interim before its
reworked to include the extra bytes?
Is it a case of its in our 4.7 branch but not in the 4.10 branch? In that case please
do merge to 4.10, as we don’t want to go backwards so we can continue to test with what
we have so far.
> It would be best to have both tach feedbacks for this. Whatever the current driver interface that hwmon is using provides enough functionality for reading a single rotor's feedback along with being able to set a target speed to the fans currently. Because of this, I'd prefer that we focus on getting the dual tach feedback added and merge the complete driver then.
>>> At this point in time, it's important we get the MAX31785 driver updated
>>> with this support along with the PCA9552 driver presence & led verification
>>> of the fan enclosures.
More information about the openbmc