[PATCH] drivers/misc: Aspeed LPC control fix format string warning

Cyril Bur cyrilbur at gmail.com
Thu Mar 23 15:29:05 AEDT 2017


resource_size_t is a derivative of phys_addr_t and should also be
printed with %pap:
    drivers/misc/aspeed-lpc-ctrl.c:232:17: warning: format '%x' expects
    argument of type 'unsigned int', but argument 4 has type
    'resource_size_t {aka long long unsigned int}' [-Wformat=] dev_info(dev,
    "Loaded at %pap (0x%08x)\n",

Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>
Signed-off-by: Cyril Bur <cyrilbur at gmail.com>
---
 drivers/misc/aspeed-lpc-ctrl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/aspeed-lpc-ctrl.c b/drivers/misc/aspeed-lpc-ctrl.c
index c654651a7b6d..2f6bb2244be5 100644
--- a/drivers/misc/aspeed-lpc-ctrl.c
+++ b/drivers/misc/aspeed-lpc-ctrl.c
@@ -229,8 +229,8 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev)
 	if (rc)
 		dev_err(dev, "Unable to register device\n");
 	else
-		dev_info(dev, "Loaded at %pap (0x%08x)\n",
-			&lpc_ctrl->mem_base, lpc_ctrl->mem_size);
+		dev_info(dev, "Loaded at %pap (%pap)\n",
+			&lpc_ctrl->mem_base, &lpc_ctrl->mem_size);
 
 	return rc;
 }
-- 
2.12.1



More information about the openbmc mailing list