[PATCH 07/17] aspeed: Refactor AST2500 RAM Driver and Sysreset Driver

Simon Glass sjg at chromium.org
Wed Mar 22 10:22:20 AEDT 2017


Hi Maxim,

On 16 March 2017 at 15:36, Maxim Sloyko <maxims at google.com> wrote:
> This change switches all existing users of ast2500 Watchdog to Driver
> Model based Watchdog driver.
>
> To perform system reset Sysreset Driver uses first Watchdog device found
> via uclass_first_device call. Since the system is going to be reset
> anyway it does not make much difference which watchdog is used.
>
> Instead of using Watchdog to reset itself, SDRAM driver now uses Reset
> driver to do that.
>
> These were the only users of the old Watchdog API, so that API is
> removed.
>
> This all is done in one change to avoid having to maintain dual API for
> watchdog in between.
>
> Signed-off-by: Maxim Sloyko <maxims at google.com>
> ---
>
>  arch/arm/include/asm/arch-aspeed/wdt.h       | 39 ---------------------
>  arch/arm/mach-aspeed/Kconfig                 |  8 +----
>  arch/arm/mach-aspeed/ast2500/sdram_ast2500.c | 12 +++++--
>  arch/arm/mach-aspeed/ast_wdt.c               | 51 ----------------------------
>  configs/evb-ast2500_defconfig                |  2 ++
>  drivers/sysreset/sysreset_ast.c              | 24 ++++++-------
>  6 files changed, 24 insertions(+), 112 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

OK, ignore my earlier comment on removing ast_wdt.c as I see you do it here.

Regards,
Simon


More information about the openbmc mailing list