[PATCH linux dev-4.7] ARM: dts: aspeed: romulus: Add GPIO hogs for nic_mode_func

Joel Stanley joel at jms.id.au
Tue Mar 21 11:44:00 AEDT 2017


On Wed, Mar 15, 2017 at 5:43 PM, Lei YU <mine260309 at gmail.com> wrote:
> GPIOD3/D4 are the "NIC_FUNC_MODE_0/1" pins connected to Broadcom
> 5719 which control the PCIe functions.
> Add GPIO hogs to pull down GPIOD3/D4 to use that function.

On other systems we had three GPIOs that set the mode of the NIC. I
notice the schematic for romulus has three FUNC_MODE pins. Is there a
reason you're only setting two of them?

I have applied this to dev-4.7. Please send a follow up for
FUNC_MODE_2 if you want to set that.

Cheers,

Joel


>
> Signed-off-by: Lei YU <mine260309 at gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> index b8b2d7f..2266c85 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> @@ -181,6 +181,21 @@
>         status = "disabled";
>  };
>
> +&gpio {
> +    nic_func_mode0 {
> +               gpio-hog;
> +               gpios = <ASPEED_GPIO(D, 3) GPIO_ACTIVE_HIGH>;
> +               output-low;
> +               line-name = "nic_func_mode0";
> +    };
> +    nic_func_mode1 {
> +               gpio-hog;
> +               gpios = <ASPEED_GPIO(D, 4) GPIO_ACTIVE_HIGH>;
> +               output-low;
> +               line-name = "nic_func_mode1";
> +    };
> +};
> +
>  &vuart {
>         status = "okay";
>  };
> --
> 1.9.1
>


More information about the openbmc mailing list