[PATCH linux dev-4.7] drivers/fsi: Flag FSI bus errors with dev_err( )

[Joel Stanley]

On Fri, Mar 10, 2017 at 1:28 AM, Christopher Bostic
<cbostic at linux.vnet.ibm.com> wrote:
>
>
> On 3/9/17 4:51 AM, Joel Stanley wrote:
>>
>> On Thu, Mar 9, 2017 at 10:32 AM, Christopher Bostic
>> <cbostic at linux.vnet.ibm.com> wrote:
>>>
>>> Currently not seeing details of any FSI bus errors that may
>>> occur.  Send info via dev_err so that the type of FSI bus fail
>>> can be determined.
>>
>> Are these really errors for normal users of the system?
>>
>> I think these will only be useful for FSI developers. Use the dynamic
>> debug system for having developer errors.
>
> Hi Joel,
>
> On second thought I think the dynamic debug facilities will be enough.
> This change will generate more spam to console for benign bus errors during
> the normal scan process.   I'll cancel submission.

Thanks for taking the time to consider. I agree that for now it would
be too much noise.

As the driver and userspace matures, we should make sure the userspace
performs appropriate error handing and logging.

Cheers,

Joel