[PATCH linux dev-4.7 v2] drivers/fsi: Change hub sysfs name

Christopher Bostic cbostic at linux.vnet.ibm.com
Fri Mar 3 08:46:25 AEDT 2017


Fix duplicate "hub at 00" naming bug when two or more hubs are
detected during scan. Each hub was assigned id '00'. Duplicate
hub device names were causing kernel warnings to console on
every scan.  Create a unique name by using the upstream master's
idx field. i.e. hub at 00, hub at 01, ...

Signed-off-by: Christopher Bostic <cbostic at linux.vnet.ibm.com>
---
v2:
    Add more description for the change.
---
 drivers/fsi/fsi-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index 542544e..b9573c5 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -437,7 +437,7 @@ static int fsi_slave_scan(struct fsi_slave *slave)
 				return -ENOMEM;
 
 			device_initialize(&hub->dev);
-			dev_set_name(&hub->dev, "hub@%02x", hub->master.idx);
+			dev_set_name(&hub->dev, "hub@%02x", slave->master->idx);
 			hub->dev.release = hub_master_release;
 			rc = device_add(&hub->dev);
 			if (rc)
-- 
1.8.2.2



More information about the openbmc mailing list