[PATCH linux dev-4.7] drivers/fsi: Change hub sysfs name

[Christopher Bostic]

On 3/1/17 6:29 PM, Joel Stanley wrote:
> On Wed, Mar 1, 2017 at 4:37 AM, Christopher Bostic
> <cbostic at linux.vnet.ibm.com> wrote:
>> Use the slave's master ID as the ID for the hub master.
> I don't know enough about how the driver works to know if this is the
> right thing to do. Is it fixing a bug? Why was the old value wrong?
>
Hi Joel,

Yes this is fixing a bug.  Before this fix both hub masters detected 
-one on first p9, other on second p9, are assigned the name "hub at 00".  
The duplicate name causes a kernel warning to console. With this change 
each hub master is named uniquely by using the ID of its upstream fsi 
master.

Thanks,
Chris
> Cheers,
>
> Joel
>
>> Signed-off-by: Christopher Bostic <cbostic at linux.vnet.ibm.com>
>> ---
>>   drivers/fsi/fsi-core.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
>> index 542544e..b9573c5 100644
>> --- a/drivers/fsi/fsi-core.c
>> +++ b/drivers/fsi/fsi-core.c
>> @@ -437,7 +437,7 @@ static int fsi_slave_scan(struct fsi_slave *slave)
>>                                  return -ENOMEM;
>>
>>                          device_initialize(&hub->dev);
>> -                       dev_set_name(&hub->dev, "hub@%02x", hub->master.idx);
>> +                       dev_set_name(&hub->dev, "hub@%02x", slave->master->idx);
>>                          hub->dev.release = hub_master_release;
>>                          rc = device_add(&hub->dev);
>>                          if (rc)
>> --
>> 1.8.2.2
>>