[PATCH v2] ARM: dts: aspeed: zaius add reg field to pca9541a i2c mux

Joel Stanley joel at jms.id.au
Thu Mar 2 11:30:04 AEDT 2017

On Thu, Mar 2, 2017 at 10:56 AM, Joel Stanley <joel at jms.id.au> wrote:
> Hey Emily,
> Welcome to OpenBMC! I maintain the kernel tree for the project.
> When you're sending patches for our fork of Linux I encourage
> developers to put the project and branch they're targeting in the
> patch prefix. This helps me out as we use the list for a few things
> other than Linux:
> https://github.com/openbmc/linux/wiki/TipsAndTricks#sending-patches
> git format-patch --subject-prefix="PATCH linux dev-4.7"
> On Thu, Mar 2, 2017 at 9:13 AM, Emily Shaffer <emilyshaffer at google.com> wrote:
>> I2C mux pca9541a at 70 for Zaius was incorrectly configured, preventing
>> hotswap at 10 LM5066I hotswap controller from being configured at startup.
>> Adding the missing field results in the hotswap controller being present
>> immediately at boot.
> I wasn't sure why this would fix things. I had a chat with Xo and he explained:
> 09:28 <@shenki> GHF[m]: but i wasn't sure why adding the reg property
> changed things?
> 09:28 <@shenki> GHF[m]: was it not binding without the reg?
> 09:28 <@shenki> there's no device tree bindings that match what zaius
> is doing, so it's hard to check
> 10:44 < GHF[m]> shenki: correct, no i2c slave device for the hotswap
> controller was instantiated and the lm5066 driver did not bind
> 10:45 < GHF[m]> shenki: actually Emily noted that it did bind if the
> device name were changed to "lm5066" suggesting that the of_*
> compatible property match wasn't working
> 10:46 < GHF[m]> shenki: no idea why the reg property one level up
> affects that ¯_(ツ)_/¯
> 10:47 <@shenki> GHF[m]: okay. i will merge it for now
> I've applied your patch to dev-4.7 with Xo's review.

I applied it, but then noticed this adds a build warning:

Warning (reg_format): "reg" property in
/ahb/apb/i2c at 1e78a000/i2c-bus at 300/pca9541a at 70/i2c-arb has invalid
length (4 bytes) (#address-cells == 2, #size-cells == 1)
Warning (avoid_default_addr_size): Relying on default #address-cells
value for /ahb/apb/i2c at 1e78a000/i2c-bus at 300/pca9541a at 70/i2c-arb
Warning (avoid_default_addr_size): Relying on default #size-cells
value for /ahb/apb/i2c at 1e78a000/i2c-bus at 300/pca9541a at 70/i2c-arb

Can you please send a v3?



More information about the openbmc mailing list