[PATCH linux dev-4.10] Add fan card PCA9552 to Witherspoon devicetree

Joel Stanley joel at jms.id.au
Tue Jun 27 19:33:23 AEST 2017


On Tue, Jun 27, 2017 at 3:43 PM, C├ędric Le Goater <clg at kaod.org> wrote:
> On 06/26/2017 08:16 AM, Joel Stanley wrote:
>> Hello Brandon,
>>
>> On Sat, Jun 24, 2017 at 9:26 AM, Brandon Wyman <bjwyman at gmail.com> wrote:
>>> The Witherspoon OpenBMC system has a PCA9552 chip on the fan card that
>>> is used for fan fault and identify LED control. Adding this chip and the
>>> LED lines to the device tree.
>>
>> Great first submission. One issue I found, please see below.
>
> Joel,
>
> haven't you merged the patch defining all the PCA9552 pins as GPIOS ?
>
> https://github.com/openbmc/linux/commit/db30464ee579176abc82d0fe95aa9b9ff76d0c3a

Yeah. We have a few PCA955x devices in the system.

There's the pca9552 used as GPIOs for the GPUs that you worked on the
driver for. There's also a pca9551 that's used for driving LEDs, which
is what Brandon is working on.

Cheers,

Joel


More information about the openbmc mailing list