[PATCH linux dev-4.10] Add fan card PCA9552 to Witherspoon devicetree

[Matt Spinler]

A few comments on naming below.  The names here have to match up with 
the MRW XML so code can find them, and we already took a shot at naming 
them in the XML.

On 6/23/2017 6:56 PM, Brandon Wyman wrote:
> The Witherspoon OpenBMC system has a PCA9552 chip on the fan card that
> is used for fan fault and identify LED control. Adding this chip and the
> LED lines to the device tree.
>
> Signed-off-by: Brandon Wyman <bjwyman at gmail.com>
> ---
>   arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 47 ++++++++++++++++++++++++
>   1 file changed, 47 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index 31315d0..e5e3b37 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -203,6 +203,53 @@
>   		compatible = "infineon,dps310";
>   		reg = <0x76>;
>   	};
> +
> +	pca0: pca9552 at 60 {
> +		compatible = "nxp,pca9552";
> +		reg = <0x60>;
> +		fan0: led at 0 {
> +			label = "fan0:yellow";
These are all fan fault LEDs.  The MRW just calls them fan0, fan1, etc.  
I suppose fan0-fault would be OK here too and we could update the MRW.
> +			default-state = "keep";
> +			reg = <0>;
> +			type = <PCA955X_TYPE_LED>;
> +		};
> +		fan1: led at 1 {
> +			label = "fan1:yellow";
> +			default-state = "keep";
> +			reg = <1>;
> +			type = <PCA955X_TYPE_LED>;
> +		};
> +		fan2: led at 2 {
> +			label = "fan2:yellow";
> +			default-state = "keep";
> +			reg = <2>;
> +			type = <PCA955X_TYPE_LED>;
> +		};
> +		fan3: led at 3 {
> +			label = "fan3:yellow";
> +			default-state = "keep";
> +			reg = <3>;
> +			type = <PCA955X_TYPE_LED>;
> +		};
> +		led at 13 {
> +			label = "yellow";
The fault LED in the back of the system is already called rear-fault, so 
this should probably be front-fault.
> +			default-state = "keep";
> +			reg = <13>;
> +			type = <PCA955X_TYPE_LED>;
> +		};
> +		led at 14 {
> +			label = "green";
front-power
> +			default-state = "keep";
> +			reg = <14>;
> +			type = <PCA955X_TYPE_LED>;
> +		};
> +		led at 15 {
> +			label = "blue";
front-id
> +			default-state = "keep";
> +			reg = <15>;
> +			type = <PCA955X_TYPE_LED>;
> +		};
> +	};
>   };
>
>   &i2c4 {