[PATCH u-boot v2016.07-aspeed-openbmc] Add ast-g5 ncsi 2nd boot config.

Joel Stanley joel at jms.id.au
Mon Jun 26 20:12:59 AEST 2017

On Fri, Jun 2, 2017 at 6:48 PM, Mykola Kostenok <c_mykolak at mellanox.com> wrote:
> Add ncsi 2nd boot aspeed g5 configuration header.
> It based on ast-g5-ncsi.h extended with defines for memtest.

I was hoping to merge these changes into the normal configurations,
instead of having a separate config.

The only difference is the presence of the SYS_MEMTEST defines.

> +/* platform.S settings */
> +#define        CONFIG_DRAM_ECC_SIZE            0x10000000
> +
> +#define CONFIG_SYS_MEMTEST_SIZE        128 * 1024 * 1024 /* 128MB */

I was looking at the u-boot tree, and it appears that these
SYS_MEMTEST defines are used by the mtest command, and the mtest
command is deprecated:

2. The "mtest" command.

   This is probably the best known memory test utility in U-Boot.
   Unfortunately, it is also the most problematic, and the most
   useless one.

   Because of these issues, the "mtest" command is considered depre-
   cated.  It should not be enabled in most normal ports of U-Boot,
   especially not in production.  If you really need a memory test,
   then see 1. and 3. above resp. below.

Are you sure that you want to enable the mtest command?



> +
> +#endif /* __AST_G5_NCSI_2BOOT_CONFIG_H */
> --
> 2.11.0

More information about the openbmc mailing list