[Skiboot] [PATCH v4] pflash option to retrieve PNOR partition flags

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jun 26 18:41:21 AEST 2017


Cyril Bur <cyrilbur at gmail.com> writes:

> On Tue, 2017-06-20 at 22:49 -0500, Michael Tritz wrote:
>> This commit extends pflash with an option to retrieve and print
>> information for a particular partition, including the content from
>> "pflash -i" and a verbose list of set miscellaneous flags. -i option
>> is also updated to print a short list of flags in addition to the
>> ECC flag, with one character per flag. A test of the new option is
>> included in libflash/test.
>
> I wonder if we should bikeshed the layout of print_partition_detail(),
> I'm absolutely not the person to review that kind of thing.
>
> I think it makes more sense for the changes to the libffs interface to
> be a separate patch.

I don't have a problem taking it as one patch, at least then we merge in
a user at the same time

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the openbmc mailing list