[PATCH linux dev-4.10] drivers/fsi: Break and set pin states on GPIO master remove

Jeremy Kerr jk at ozlabs.org
Wed Jun 7 13:22:11 AEST 2017


Hi Chris,

> Update GPIO remove behavior to match dev-4.7.
> 
> On gpio remove: Send a break
> 		clock, translator, mux = 0
> 		data, enable = 1

While this change itself seems okay (leaving GPIOs in a defined state),
I'm concerned about *why* we need this.

If there is other code that need GPIOs in a certain state, then that
code should be doing the required init itself.

Could you add a comment on why this is required?

Cheers,


Jeremy


More information about the openbmc mailing list