[RFC PATCH linux dev-4.10 0/7] Add fast rotor reads to MAX31785

Joel Stanley joel at jms.id.au
Mon Jun 5 16:01:44 AEST 2017

On Fri, Jun 2, 2017 at 3:52 PM, Andrew Jeffery <andrew at aj.id.au> wrote:
> Hello,
> I've dodgied up this series with a patch to the i2c core to make the fast rotor
> read documented in [1] work. Thus, it's an RFC series. Further, the fast rotor
> values are zero on the machine I was testing against. Maybe I need to broaden
> my horizons and test against more machines, but I figured I'd send the patches
> to get some "internal" feedback.
> Timothy's original patch is reworked against the new hwmon kernel APIs. The
> rework made it easier to support both the 0x3030 and 0x3040 firmwares for the
> approach I took, though maybe there is a better way with using the hwmon
> attribute visibility modes. Further, it's still not a pmbus driver, so it's
> probably not yet acceptible upstream despite the fact that upstream still
> doesn't support fan control in the pmbus core.

Looks good.

I suggest we send it upstream with patches 1, 3, 4, 6 squashed into
one. Make sure we retain Timothy's copyright in the header.

Instead of using your i2c DWORD hack, use i2c_master_recv to do your
four byte transfer. Call out in a comment or your commit message that
the smbus spec doesn't define a 4 byte transfer, but the device needs



More information about the openbmc mailing list