[PATCH linux dev-4.10 v3 2/4] dt-bindings: watchdog: aspeed: External reset signal properties

[Andrew Jeffery]

On Fri, 2017-07-28 at 11:11 +0930, Joel Stanley wrote:
> > On Thu, Jul 27, 2017 at 7:46 PM, Andrew Jeffery <andrew at aj.id.au> wrote:
> > For the AST2500 and compatible watchdog controllers the external reset
> > signal can be configured for push-pull or open-drain drive types, and in
> > the case of open-drain driving, active low or high.
> 
> In addition to this we should document the pinctrl phandle: the fact
> that it exists, but more importantly how that interacts with the
> hardware.

Yeah that's a good suggestion. I'll make a separate patch augmenting
Chris' words for aspeed,external-signal, and I'll hold off on resending
the series until I get some feedback from Matt Spinler on whether it's
fit for purpose.

> 
> > 
> > > > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> > ---
> >  Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 10 +++++++++-
> >  1 file changed, 9 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> > index f526b003b2e0..7aa885f620ef 100644
> > --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> > +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt
> > @@ -36,10 +36,18 @@ Optional properties:
> >   - aspeed,interrupt:   If property is present then interrupt CPU.
> >                         If not specified then don't interrupt CPU.
> > 
> > + - aspeed,alt-boot:    If property is present then boot from alternate block.
> >   - aspeed,external-signal: If property is present then signal is sent to
> >                         external reset counter (only WDT1 and WDT2). If not
> >                         specified no external signal is sent.
> > - - aspeed,alt-boot:    If property is present then boot from alternate block.
> > + - aspeed,ext-pulse-duration: External signal pulse duration in microseconds
> > +
> > +Optional properties for AST2500-compatible watchdogs:
> > + - aspeed,ext-push-pull: If aspeed,external-signal is present, set the pin's
> > +                        drive type to push-pull. The default is open-drain.
> > + - aspeed,ext-active-high: If aspeed,external-signal is present and and the pin
> > +                          is configured as push-pull, then set the pulse
> > +                          polarity to active-high. The default is active-low.
> > 
> >  Example:
> > 
> > --
> > 2.11.0
> > 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170728/765b2e6b/attachment.sig>