[PATCH linux dev-4.10 v4] ARM: dts: aspeed: Add gpio-keys-polled for fan presence

[Christopher Bostic]

On 7/26/17 7:14 AM, Joel Stanley wrote:
> Hi Chris,
>
> On Thu, Jul 20, 2017 at 11:45 PM, Christopher Bostic
> <cbostic at linux.vnet.ibm.com> wrote:
>> +       gpio-keys-polled {
>> +               compatible = "gpio-keys-polled";
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               #poll-interval = <1000>;
> When I tested it, I saw this:
>
> [    3.630000] gpio-keys-polled gpio-keys-polled: missing poll_interval value
> [    3.630000] gpio-keys-polled: probe of gpio-keys-polled failed with error -22
>
> I fixed that property, and I got this:
>
> [    3.620000] OF: /gpio-keys-polled/fan0-presence: could not get
> #gpio-cells for /ahb/apb/i2c at 1e78a000/i2c-bus at 100/pca9552 at 60
> [    3.620000] gpio-keys-polled gpio-keys-polled: failed to get gpio: -22
> [    3.620000] gpio-keys-polled: probe of gpio-keys-polled failed with error -22
Sorry about that -missed the probe error, will fix.


Thanks,
Chris


> So I added the gpio-cells to the relevant node, and it probed properly.
>
> Can you please make those two fixes and test that the input events
> work as you expected?
>
> Cheers,
>
> Joel
>