[PATCH linux dev-4.10 v2 4/4] ARM: dts: aspeed: Witherspoon WDT1 external signal is push-pull

[Andrew Jeffery]

On Thu, Jul 27, 2017, at 03:24, Matt Spinler wrote:
> 
> 
> On 7/26/2017 11:08 AM, Andrew Jeffery wrote:
> > Correctly drive the latch asserting the FAULT pin on the MAX31785 when
> > the watchdog bites. This ensures the fan outputs are ramped to 100% PWM
> > duty.
> >
> > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> > ---
> >   arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> > index c28222c17d03..df36b87ba105 100644
> > --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> > +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> > @@ -488,6 +488,7 @@
> >   &wdt1 {
> >   	aspeed,reset-type = "none";
> >   	aspeed,external-signal;
> > +	aspeed,ext-push-pull;
> 
> We need active-high for sure.  It still works without push-pull, but not 
> sure if that is totally electronically ideal or not as the HW designer 
> requested for this to be push-pull.

Right; given Jordan's statement, the wording of the documentation and
your testing the behaviour doesn't entirely make sense to me.

I might try to get it clarified with Aspeed.

Andrew

> 
> >
> >   	pinctrl-names = "default";
> >   	pinctrl-0 = <&pinctrl_wdtrst1_default>;
>