[PATCH linux dev-4.10] mtd: spi-nor: aspeed: set 4B setting for all chips

Cédric Le Goater clg at kaod.org
Tue Jul 25 20:00:03 AEST 2017


On 07/25/2017 05:51 AM, Joel Stanley wrote:
> On Mon, Jul 24, 2017 at 7:10 PM, Cédric Le Goater <clg at kaod.org> wrote:
>> The driver made the wrong assumption that the 4B setting was
>> autodetected for all chips of the AST2500 FMC flash controller. This
>> is only the case for the CS0.
>>
>> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> 
> I tested this on a witherspoon and it appeared to work. I have applied
> it to dev-4.10. Thanks for hunting it down!
> 
> root at spoon1-bmc:~# time flashcp /tmp/flash-witherspoon /dev/mtd6
> real 3m44.212s
> user 0m0.750s
> sys 3m42.620s

It can be improved with a spi-max-frequency property to set 
the hclk divider. I sent a patch for it but it is not entirely
correct as the hclk divider is set a little too early.

C.


More information about the openbmc mailing list