[PATCH linux dev-4.10 v2] ARM: dts: aspeed: firestone: Fix i2c addresses

Andrew Jeffery andrew at aj.id.au
Tue Jul 25 19:54:41 AEST 2017


On Tue, Jul 25, 2017, at 16:54, Joel Stanley wrote:
> With the 10 bit addresses we fail to probe.
> 
> After this change, the drivers correctly probe on a Firestone system with
> this
> kernel.
> 
> Signed-off-by: Joel Stanley <joel at jms.id.au>

Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

> ---
> v2:
>  - match node names to addresses
>  - fix tpm address
>  - add ucd, found this was present while browsing datasheet
> 
>  arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts | 33
>  +++++++++++++++-----------
>  1 file changed, 19 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> index 794e8fafbd3e..3d4232975b7f 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts
> @@ -142,9 +142,9 @@
>  		reg = <0x50>;
>  	};
>  
> -       tmp423 at 98 {
> +       tmp423 at 4c {
>  		compatible = "ti,tmp423";
> -               reg = <0x80000098>;
> +               reg = <0x4c>;
>  	};
>  };
>  
> @@ -157,9 +157,9 @@
>  		reg = <0x50>;
>  	};
>  
> -       tmp423 at 98 {
> +       tmp423 at 4c {
>  		compatible = "ti,tmp423";
> -               reg = <0x80000098>;
> +               reg = <0x4c>;
>  	};
>  };
>  
> @@ -189,31 +189,36 @@
>  &i2c11 {
>  	status = "okay";
>  
> -       leds at c0 {
> +       leds at 60 {
>  		compatible = "pca,pca9552led";
> -               reg = <0x800000c0>;
> +               reg = <0x60>;
>  		// led9 - led_fault_n
>  		// led10 - pwr_led_n
>  		// led11 - rear_id_led_n
>  	};
>  
> -       rtc at d0 {
> +       rtc at 68 {
>  		compatible = "dallas,ds3231";
> -               reg = <0x800000d0>;
> +               reg = <0x68>;
>  	};
>  
> -       si5338a at e2 {
> +       si5338a at 71 {
>  		// SiLabs clock generator
> -               reg =<0x800000e2>;
> +               reg =<0x71>;
>  	};
>  
> -       idt at d6 {
> +       idt at 6b {
>  		// IDT 9DBV0641 clock buffer
> -               reg = <0x800000d6>;
> +               reg = <0x6b>;
>  	};
>  
> -       tpm at a3 {
> -               reg = <0x800000a3>;
> +       tpm at 57 {
> +               reg = <0x57>;
> +       };
> +
> +       ucd at 64 {
> +               compatible = "ti,ucd90160";
> +               reg = <0x64>
>  	};
>  };
>  
> -- 
> 2.13.3
> 


More information about the openbmc mailing list