[PATCH v2 1/2] ARM: dts: aspeed: Add gpio-keys-polled for fan presence

[Joel Stanley]

On Wed, Jul 19, 2017 at 6:13 AM, Christopher Bostic
<cbostic at linux.vnet.ibm.com> wrote:
>
> +       gpio-keys-polled {
> +               compatible = "gpio-keys-polled";
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               #poll-interval = <100>;

Are you sure that this needs to be polled this often?

We should consider how much traffic this generates on the bus (how
often it is contended), and how that fits in with other devices on
that master. If you've done these calculations then please amend your
commit message with that information.

> +               autorepeat;

None of the other gpio-keys nodes have this set. Can you expand your
commit message to explain why you set this please.

> @@ -224,6 +256,8 @@
>                 reg = <0x60>;
>                 #address-cells = <1>;
>                 #size-cells = <0>;
> +               gpio-controller;
> +               #gpio-cells = <2>;

This appears to be an unrelated change?

Cheers,

Joel