[PATCH linux dev-4.10] hwmon: (aspeed-pwm-tacho) cooling device support

[Mykola Kostenok]

Hi Patrick,

Ok I'll send driver patch to upstream.
And when it will be accepted. I will send separate patches for driver and dts to openbmc.

Thanks for your help.

Best regards. Mykola Kostenok.

> -----Original Message-----
> From: Patrick Williams [mailto:patrick at stwcx.xyz]
> Sent: Thursday, July 6, 2017 6:57 PM
> To: Mykola Kostenok <c_mykolak at mellanox.com>
> Cc: Joel Stanley <joel at jms.id.au>; openbmc at lists.ozlabs.org; Patrick
> Venture <venture at google.com>
> Subject: Re: [PATCH linux dev-4.10] hwmon: (aspeed-pwm-tacho) cooling
> device support
> 
> On Tue, Jul 04, 2017 at 04:56:08PM +0300, Mykola Kostenok wrote:
> > Add support in aspeed-pwm-tacho driver for cooling device creation.
> > This cooling device could be bound to a thermal zone for the thermal
> > control. Device will appear in /sys/class/thermal folder as
> > cooling_deviceX. Then it could be bound to particular thermal zones.
> > Allow specification of the cooling levels vector - PWM duty cycle
> > values in a range from 0 to 255 which correspond to thermal cooling
> > states.
> >
> > Add basic pwm-tacho-controller node to ast-g5 dtsi.
> > Add basic pwm-tacho-controller node to ast-g4 dtsi.
> >
> > Change pwm-tacho in aspeed-bmc-quanta-q71l.dts according new pwm-
> tacho
> > structure.
> >
> > Add pwm-tacho to aspeed-bmc-mellanox-msn.dts.
> >
> > Signed-off-by: Mykola Kostenok <c_mykolak at mellanox.com>
> > ---
> >  arch/arm/boot/dts/aspeed-bmc-mellanox-msn.dts |  61 +++++++++++
> > arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts  | 103 +++++++++---------
> -
> >  arch/arm/boot/dts/aspeed-g4.dtsi              |   9 +-
> >  arch/arm/boot/dts/aspeed-g5.dtsi              |  17 ++++
> >  drivers/hwmon/aspeed-pwm-tacho.c              | 139
> +++++++++++++++++++++++++-
> 
> This commit is both modifying a set of device trees and adding support to the
> hwmon driver.  Don't we need these as two separate commits?  The hwmon
> driver changes should go upstream first to get feedback from the hwmon
> subsystem owner and then we can backport them into the current
> OpenBMC kernel.
> 
> https://github.com/openbmc/docs/blob/master/kernel-development.md
> 
> --
> Patrick Williams