[PATCH linux dev-4.10] ARM: dts: aspeed: Set quality factor

Joel Stanley joel at jms.id.au
Tue Jul 4 16:05:28 AEST 2017


>From the timeriomem_rng bindings:

 quality: estimated number of bits of true entropy per 1024 bits read
 from the rng.  Defaults to zero which causes the kernel's default
 quality to be used instead.  Note that the default quality is usually
 zero which disables using this rng to automatically fill the kernel's
 entropy pool.

As to the recommended value for us to use:

Rick Altherr <raltherr at google.com> wrote:
> Quality is #bit of entropy per 1000 bits read.  100 is a
> conservative value that was suggested by those in the know.

Signed-off-by: Joel Stanley <joel at jms.id.au>
---
 arch/arm/boot/dts/aspeed-g4.dtsi | 1 +
 arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
 2 files changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
index 9cc959fccfa0..470a6335399a 100644
--- a/arch/arm/boot/dts/aspeed-g4.dtsi
+++ b/arch/arm/boot/dts/aspeed-g4.dtsi
@@ -193,6 +193,7 @@
 					compatible = "timeriomem_rng";
 					reg = <0x1e6e2078 0x4>;
 					period = <1>;
+					quality = <100>;
 				};
 
 				pinctrl: pinctrl at 1e6e2000 {
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 992242d3b22e..466b322951e1 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -232,6 +232,7 @@
 				compatible = "timeriomem_rng";
 				reg = <0x1e6e2078 0x4>;
 				period = <1>;
+				quality = <100>;
 			};
 
 			gfx: display at 1e6e6000 {
-- 
2.13.2



More information about the openbmc mailing list