[PATCH] arm: dts: aspeed: witherspoon: Add devices

Patrick Williams patrick at stwcx.xyz
Tue Jan 17 07:36:24 AEDT 2017

On Mon, Jan 16, 2017 at 01:43:32PM -0600, Matt Spinler wrote:
> >> +
> >> +       leds {
> >> +               compatible = "gpio-leds";
> >> +
> >> +               rear-fault-led {
> > Follow the naming of the other machines. This should be "rear-fault".
> >
> > Are there other fault leds? If not, call it "fault".
> There's also a set of front LEDs for these functions.  They're off of a 
> 9552 and just I haven't gotten to their representation yet.
> When I eventually get the autogeneration of the device tree working, 
> these names will be whatever they show up as in the MRW.
> I will change these to 'rear-fault', etc.

Is there any concern with name collisions with removing the 'led'
portion of the name?  If, for example,  we have a button (GPIO) and LED
with the name 'power is there any problem instead of being named
'power-button' and 'power-led'?

Patrick Williams
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170116/3ac52135/attachment.sig>

More information about the openbmc mailing list