[PATCH] arm: dts: aspeed: witherspoon: Add devices

[Joel Stanley]

On Sat, Jan 14, 2017 at 6:23 AM, Matt Spinler
<mspinler at linux.vnet.ibm.com> wrote:
> From: Matt Spinler <spinler at us.ibm.com>
>
> Add more I2C devices and the rear LEDs.

Please make the subject line more descriptive. "add i2c and led devices".

>
> Signed-off-by: Matt Spinler <spinler at us.ibm.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 39 ++++++++++++++++++++++--
>  1 file changed, 36 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index 9badf3e94599..11de7a957738 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -19,6 +19,22 @@
>         memory {
>                 reg = <0x80000000 0x40000000>;
>         };
> +
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               rear-fault-led {

Follow the naming of the other machines. This should be "rear-fault".

Are there other fault leds? If not, call it "fault".

> +                       gpios = <&gpio ASPEED_GPIO(N, 2) GPIO_ACTIVE_LOW>;

Did you attempt to compile this patch? It doesn't build for me, with
the first error on this line.

> +               };
> +
> +               rear-id-led {

Same here. Call it "identify". as in the other dts.

> +                       gpios = <&gpio ASPEED_GPIO(N, 4) GPIO_ACTIVE_LOW>;
> +               };
> +
> +               rear-power-led {

power.

> +                       gpios = <&gpio ASPEED_GPIO(N, 3) GPIO_ACTIVE_LOW>;
> +               };
> +       };
>  };
>
>  &fmc {
> @@ -115,25 +131,38 @@
>                 compatible = "bosch,bmp180";
>                 reg = <0x77>;
>         };
> +
> +       max31785 at 52 {
> +               compatible = "maxim,max31785";
> +               reg = <0x52>;
> +       };
>  };
>
>  &i2c4 {
>         status = "okay";
>
> -       /* CP1 TMP423A */
>         /* CP1 VDN & VDDR */
>         /* CP1 VDD & VCS */
>         /* CP1 VIO */
> +
> +       tmp423a at 4c {
> +               compatible = "ti,tmp423";
> +               reg = <0x4c>;
> +       };
>  };
>
>
>  &i2c5 {
>         status = "okay";
>
> -       /* CP1 TMP423A */
>         /* CP1 VDN & VDDR */
>         /* CP1 VDD & VCS */
>         /* CP1 VIO */
> +
> +       tmp423a at 4c {
> +               compatible = "ti,tmp423";
> +               reg = <0x4c>;
> +       };
>  };
>
>  &i2c6 {
> @@ -152,13 +181,17 @@
>  &i2c9 {
>         status = "okay";
>
> -       /* Tmp275 */
>
>         /* MUX
>          *    -> PCIe Slot 3
>          *    -> PCIe Slot 4
>          *    -> PCA9517 -> PEX8725
>          */
> +
> +       tmp275 at 4a {
> +               compatible = "ti,tmp275";
> +               reg = <0x4a>;
> +       };
>  };
>
>  &i2c10 {
> --
> 2.11.0
>
> _______________________________________________
> openbmc mailing list
> openbmc at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/openbmc