[PATCH v2 4/5] drivers/mailbox: Add aspeed ast2400/ast2500 mbox driver

Benjamin Herrenschmidt benh at au1.ibm.com
Tue Jan 10 15:28:24 AEDT 2017

On Tue, 2017-01-10 at 09:25 +1030, Andrew Jeffery wrote:
> I'm in favour of removing the ioctl. So the logic would be:
> 1. If lpos is zero, assume a MBOX_NUM_DATA_REGS-sized write as we do
> currently
> 2. If lpos is non-zero, assume a single byte write
> On that, should we be testing the assumptions about buffer sizes?
> Currently we don't (we use the MBOX_NUM_DATA_REGS rather than count).

I would enforce the lpos is some specific magic value such as 0x1000
for the special write bcs we might want to support partial writes
inside the 16 bytes area...


More information about the openbmc mailing list