[PATCH 2/2] gpio: aspeed: Support banks Y, Z, AA and BB

[Andrew Jeffery]

Hi Xo,

On Mon, 2017-01-09 at 16:24 -0800, Xo Wang wrote:
> Hi Joel,
> 
> > On Sun, Dec 11, 2016 at 8:06 PM, Joel Stanley <joel at jms.id.au> wrote:
> > These banks have extra limitations compared to those currently
> > implemented. We must detect when these unique banks are being used and
> > special case their IRQ and input state.
> >
> > TODO: Do what it says on the label
> >
> > > Signed-off-by: Joel Stanley <joel at jms.id.au>
> > ---
> >  drivers/gpio/gpio-aspeed.c | 15 ++++++++++++++-
> >  1 file changed, 14 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c
> > index d7198536de13..c4d87a2a489f 100644
> > --- a/drivers/gpio/gpio-aspeed.c
> > +++ b/drivers/gpio/gpio-aspeed.c
> > @@ -65,10 +65,14 @@ static const struct aspeed_gpio_bank aspeed_gpio_banks[] = {
> >                 .names = { "U", "V", "W", "X" },
> >         },
> >         /*
> > -        * A bank exists for { 'Y', 'Z', "AA", "AB" }, but is not implemented.
> >          * Only half of GPIOs Y support interrupt configuration, and none of Z,
> >          * AA or AB do as they are output only.
> 
> Is this comment accurate? I don't see anything in the AST2500
> datasheet about GPIOs Z, AA, and AB being output only.

These banks are output-only on the AST2400. The comment is not accurate
for the 2500 as far as I can see. Again this was a patch that needed
some improvement, we just haven't got around to cleaning it up.

Cheers,

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170110/be893af3/attachment.sig>