[PATCH linux dev-4.7 v4] drivers/fsi: Add hub master support

[Joel Stanley]

On Fri, Feb 24, 2017 at 3:29 PM, Joel Stanley <joel at jms.id.au> wrote:
> On Fri, Feb 24, 2017 at 2:46 PM, Jeremy Kerr <jk at ozlabs.org> wrote:
>> Hi Chris,
>>
>>> Scan for links off of the mFSI master on CFAM. Add any devices
>>> detected to the existing list of FSI devices and notify any
>>> clients.
>>>
>>> Signed-off-by: Christopher Bostic <cbostic at linux.vnet.ibm.com>
>>
>> Assuming all the inits are correct in hub_master_init(), and the layout
>> in sysfs is sensible, looks good to me!
>>

Note that the fsi-core.c file has a bunch of sparse warnings that you
will need to resolve:

drivers/fsi/fsi-core.c:232:5: warning: symbol 'hub_master_read' was
not declared. Should it be static?
drivers/fsi/fsi-core.c:241:5: warning: symbol 'hub_master_write' was
not declared. Should it be static?
drivers/fsi/fsi-core.c:250:5: warning: symbol 'hub_master_break' was
not declared. Should it be static?
drivers/fsi/fsi-core.c:265:5: warning: symbol 'hub_master_link_enable'
was not declared. Should it be static?
drivers/fsi/fsi-core.c:804:1: warning: symbol
'dev_attr_fsi_ipoll_period' was not declared. Should it be static?

Cheers

Joel