[PATCH linux dev-4.7 1/3] ARM: dts: aspeed-bmc-opp-romulus: Enable mailbox and LPC control nodes

Andrew Jeffery andrew at aj.id.au
Thu Feb 16 12:12:19 AEDT 2017


Hi Lei,

On Tue, 2017-02-14 at 15:25 +0800, Lei YU wrote:
> Also add the reserved-memory node needed by the LPC
> control driver.
> 
> > Signed-off-by: Lei YU <mine260309 at gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> index c23627e..f47eb63 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> @@ -19,6 +19,18 @@
> >  	memory {
> >  		reg = <0x80000000 0x40000000>;
> >  	};
> +
> > +	reserved-memory {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges;
> +
> > > +		flash_memory: region at 94000000 {
> > +			no-map;
> +			reg = <0x94000000 0x04000000>; /* 64M */

So these values are also used in the zaius dts. Why are we reserving
64M 128M down from the top of the RAM address space? Is the top 64M
meant to be reserved for anything as well? Why not reserve the top 64M?

> +		};
> > +	};
> +
>  };
>  
>  &fmc {
> @@ -44,6 +56,16 @@
> >  	};
>  };
>  
> +&lpc_ctrl {
> > +	status = "okay";
> > +	memory-region = <&flash_memory>;
> > +	flash = <&spi1>;
> +};
> +
> +&mbox {
> > +	status = "okay";
> +};

This looks fine.

Andrew
> +
>  &uart5 {
> >  	status = "okay";
>  };
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170216/7f96532b/attachment.sig>


More information about the openbmc mailing list