[PATCH linux dev-4.7 1/2] drivers: fsi: delete device on unscan

[Joel Stanley]

On Tue, Feb 14, 2017 at 6:37 AM, Eddie James <eajames at linux.vnet.ibm.com> wrote:
> From: "Edward A. James" <eajames at us.ibm.com>
>
> need to delete device so that client driver "remove" is called.
>
> Signed-off-by: Edward A. James <eajames at us.ibm.com>
> ---
>  drivers/fsi/fsi-core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
> index 1e9c5a2..e8a3618 100644
> --- a/drivers/fsi/fsi-core.c
> +++ b/drivers/fsi/fsi-core.c
> @@ -512,6 +512,7 @@ static void fsi_master_unscan(struct fsi_master *master)
>                 list_for_each_entry_safe(fsi_dev, fsi_dev_tmp,
>                                         &slave->my_engines, link) {
>                         list_del(&fsi_dev->link);
> +                       device_del(&fsi_dev->dev);
>                         put_device(&fsi_dev->dev);

put_device calls kobject_put, but device_del has already called
kobject_del. Are you sure this is what you want to do here?


>                 }
>                 device_unregister(&slave->dev);
> --
> 1.8.3.1
>