[PATCH linux dev-4.7 v3] dts: aspeed: witherspoon: Enable FSI master

Joel Stanley joel at jms.id.au
Sat Feb 11 13:47:08 AEDT 2017


On Sat, Feb 11, 2017 at 7:24 AM, Eddie James <eajames at linux.vnet.ibm.com> wrote:
> From: "Edward A. James" <eajames at us.ibm.com>
>
> set status to "okay"

Did you successfully boot a p9 with this?

I found that it did work, but we have two separate bits of software
poking at FSI - pdbg via /dev/mem, and the kernel driver. So it's a
bit of luck that it still works.

In order to not have this, pdbg needs to use the kernel driver. I
started doing this work but hit the issues that you and Chris have
been debugging for us.

On Monday I will re-test pdbg with your fixes, and if that works, we
can push the pdbg OpenFSI backend and at that point change the device
tree to bind to the driver. We will need to make sure we can use the
kernel driver to perform the DD1 workarounds on both p9 sockets.

Cheers,

Joel

>
> Signed-off-by: Edward A. James <eajames at us.ibm.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index 4b2d8aa..e532737 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -50,7 +50,7 @@
>         fsi-master {
>                 compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";
>
> -               status = "disabled";
> +               status = "okay";
>
>                 clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
>                 data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
> --
> 1.8.3.1
>


More information about the openbmc mailing list