[PATCH] ARM: dts: aspeed: Add FSI pins to Zaius device tree

[Xo Wang]

Hi Joel,

Thanks for keeping us up to date.

On Mon, Feb 6, 2017 at 6:37 PM, Joel Stanley <joel at jms.id.au> wrote:
> Pin assignments for the EVT-2 board as described in pdbg. The status is disabled
> so this does not enable the in-kernel FSI driver yet.
>
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
>
> Tested on zaius5 with the driver enabled and it worked.
>
>  arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> index e2195a641414..e1c9b3f4fe44 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> @@ -74,6 +74,18 @@
>                         gpios = <&gpio ASPEED_GPIO(AA, 2) GPIO_ACTIVE_LOW>;
>                 };
>         };
> +
> +       fsi-master {
> +               compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";

Andrew's comment for Witherspoon applies here as well
("ibm,fsi-master-gpio" makes sense as the "definitive" name).

> +
> +               status = "disabled";
> +
> +               clock-gpios = <&gpio ASPEED_GPIO(C, 3) GPIO_ACTIVE_HIGH>;
> +               data-gpios = <&gpio ASPEED_GPIO(C, 2) GPIO_ACTIVE_HIGH>;

FYI, we'll return to the Norm-recommended assignments for these at the
next board spin to keep FSI pins on their own GPIO port. Not sure how
helpful that is in the context of the FSI kernel driver since it's not
poking the registers directly.

> +               trans-gpios = <&gpio ASPEED_GPIO(O, 6) GPIO_ACTIVE_HIGH>;
> +               enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
> +               mux-gpios = <&gpio ASPEED_GPIO(P, 6) GPIO_ACTIVE_HIGH>;
> +       };
>  };
>
>  &fmc {
> --
> 2.11.0
>

cheers
xo