[PATCH linux dev-4.7] ARM: dts: aspeed: witherspoon: Add fsi-master GPIO bindings

[Andrew Jeffery]

On Fri, 2017-02-03 at 16:44 -0600, Christopher Bostic wrote:
> Define the pins used on Witherspoon by the FSI GPIO master.
> 
> > Signed-off-by: Christopher Bostic <cbostic at linux.vnet.ibm.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index 6064afa..4b2d8aa 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -46,6 +46,18 @@
> >  			gpios = <&gpio ASPEED_GPIO(N, 3) GPIO_ACTIVE_LOW>;
> >  		};
> >  	};
> +
> > +	fsi-master {
> +		compatible = "ibm,fsi-master", "ibm,fsi-master-gpio";

I think these compatibles should be the other way around if we
generalise [1] to device compatible strings:

    The 'compatible' property contains a sorted list of strings starting
    with the exact name of the machine, followed by an optional list of
    boards it is compatible with sorted from most compatible to least.  For
    example, the root compatible properties for the TI BeagleBoard and its
    successor, the BeagleBoard xM board might look like, respectively:

    	    compatible = "ti,omap3-beagleboard", "ti,omap3450", "ti,omap3";
    	    compatible = "ti,omap3-beagleboard-xm", "ti,omap3450", "ti,omap3";

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/usage-model.txt#n116

> +
> +		status = "disabled";

This is disabled because we need to improve userspace support?

> +
> > +		clock-gpios = <&gpio ASPEED_GPIO(AA, 0) GPIO_ACTIVE_HIGH>;
> > +		data-gpios = <&gpio ASPEED_GPIO(E, 0) GPIO_ACTIVE_HIGH>;
> > +		mux-gpios = <&gpio ASPEED_GPIO(A, 6) GPIO_ACTIVE_HIGH>;
> > +		enable-gpios = <&gpio ASPEED_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
> > +		trans-gpios = <&gpio ASPEED_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
> +	};

These look fine to me.

Andrew

>  };
>  
>  &fmc {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170206/41193d54/attachment.sig>