[patch v15 1/4] drivers: jtag: Add JTAG core driver

Jiri Pirko jiri at mellanox.com
Tue Dec 26 19:47:13 AEDT 2017

Tue, Dec 26, 2017 at 12:09:08AM CET, f.fainelli at gmail.com wrote:
>Le 12/25/17 à 03:53, Oleksandr Shamray a écrit :


>> +
>> +void *jtag_priv(struct jtag *jtag)
>> +{
>> +	return jtag->priv;
>> +}
>> +EXPORT_SYMBOL_GPL(jtag_priv);
>Can't you just create a static inline function in the public header for
>that? This is usually what subsystems do, I can understand why you would
>not want to expose struct jtag to other parts of the kernel, but still,
>this looks ugly, so maybe consider splitting the header between provider
>and consumer?

Other subsystems expose the struct. Here, it is intentional to don't
expose the struct, that's why we have this helper. What is ugly about
that? :)

More information about the openbmc mailing list