[PATCH 5/6] ARM: dts: aspeed: peci-hwmon: Add Aspeed PECI hwmon

[Andrew Jeffery]

On Thu, 7 Dec 2017, at 07:33, Jae Hyun Yoo wrote:
> This commit adds Aspeed PECI hwmon node into aspeed-g4 and
> aspeed-g5.
> 
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com>
> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 64
>  ++++++++++++++++++++++++++++++++++++++++
>  arch/arm/boot/dts/aspeed-g5.dtsi | 64
>  ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 128 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi
> b/arch/arm/boot/dts/aspeed-g4.dtsi
> index d45f6b67fecc..f9904c2ee5d9 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -250,6 +250,70 @@
>  				clk-div = <0>;
>  				cmd-timeout-ms = <1000>;
>  				status = "disabled";
> +
> +                               peci_hwmon0: peci-hwmon-cpu0 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <0>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon1: peci-hwmon-cpu1 {

I feel like this is all better left to the platform dts rather than
describing then disabling host topology in the SoC dtsi. This applies to
the g5 dtsi as well.

Cheers,

Andrew

> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <1>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon2: peci-hwmon-cpu2 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <2>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon3: peci-hwmon-cpu3 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <3>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon4: peci-hwmon-cpu4 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <4>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon5: peci-hwmon-cpu5 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <5>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon6: peci-hwmon-cpu6 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <6>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon7: peci-hwmon-cpu7 {
> +                                       compatible =
> "aspeed,ast2400-peci-hwmon";
> +                                       cpu-id = <7>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
>  			};
>  
>  			timer: timer at 1e782000 {
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi
> b/arch/arm/boot/dts/aspeed-g5.dtsi
> index c75998ef759c..749ed252f71e 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -301,6 +301,70 @@
>  				clk-div = <0>;
>  				cmd-timeout-ms = <1000>;
>  				status = "disabled";
> +
> +                               peci_hwmon0: peci-hwmon-cpu0 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <0>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon1: peci-hwmon-cpu1 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <1>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon2: peci-hwmon-cpu2 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <2>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon3: peci-hwmon-cpu3 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <3>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon4: peci-hwmon-cpu4 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <4>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon5: peci-hwmon-cpu5 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <5>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon6: peci-hwmon-cpu6 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <6>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
> +
> +                               peci_hwmon7: peci-hwmon-cpu7 {
> +                                       compatible =
> "aspeed,ast2500-peci-hwmon";
> +                                       cpu-id = <7>;
> +                                       show-core = <1>;
> +                                       dimm-nums = <16>;
> +                                       status = "disabled";
> +                               };
>  			};
>  
>  			timer: timer at 1e782000 {
> -- 
> 2.15.1
>