[PATCH linux dev-4.10 0/5] Retain front LED state on Witherspoon

[Brandon Wyman]

On Fri, Aug 25, 2017 at 1:52 AM, Andrew Jeffery <andrew at aj.id.au> wrote:
> Hello,
>
> This series fixes witherspoon to retain its front LED state across BMC resets.
> It was noted in issue 2156[1] that the front LEDs came on solid during a BMC
> boot. This appears to be the result of several bugs which are addressed in the
> following patches.
>
> The changes to leds-gpio have been sent upstream:
>
>   https://lkml.org/lkml/2017/8/25/44
>
> The pca955x patch depends on changes we appear to only have in the dev-4.10
> tree (i.e. they haven't been applied upstream). There's some discussion at [2]
> but I'm not aware of a follow-up patch from Cédric. Certainly applying my patch
> to upstream lead to signifiant conflicts, so I haven't yet tried to send it on
> its way.
>
> Cédric: I know you're undecided on how I've approached the pca955x patch - I
> figured we could argue about it on the list in case anyone else had helpful
> insights to settle the dispute :)
>
> The final two patches clean up the leds nodes in the Witherspoon devicetree and
> add the new retain-state-shutdown property to the necessary LEDs. I do wonder
> if we want to retain the state on the rear LEDs as well, but that requires more
> features to be added to the Aspeed GPIO controller.
>
> The patches have been tested on a Witherspoon system, albeit remotely. I can't
> put eyes on the LEDs in question so it would be good for someone who has the
> ability to do so. I used the test outlined by Vishwa at [3].
>
> Please review!
>
> Andrew
>
> [1] https://github.com/openbmc/openbmc/issues/2156
> [2] http://patchwork.ozlabs.org/patch/760006/
> [3] https://github.com/openbmc/openbmc/issues/2156#issuecomment-324101828
>
> Andrew Jeffery (5):
>   dt-bindings: leds: gpio: Add optional retain-state-shutdown property
>   leds: gpio: Allow LED to retain state at shutdown
>   leds: pca955x: Don't invert requested value in
>     pca955x_gpio_set_value()
>   aspeed: witherspoon: Tidy and unify LED nodes
>   aspeed: witherspoon: leds: Retain state across BMC resets
>
>  .../devicetree/bindings/leds/leds-gpio.txt         |  3 ++
>  arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts   | 32 ++++++++++++----------
>  drivers/leds/leds-gpio.c                           |  7 ++++-
>  drivers/leds/leds-pca955x.c                        |  7 +++--
>  include/linux/leds.h                               |  3 ++
>  5 files changed, 34 insertions(+), 18 deletions(-)
>
> --
> 2.11.0
>

Tested-by: Brandon Wyman <bjwyman at gmail.com>