[PATCH linux dev-4.10 2/2] leds: pca955x: check for I2C errors

Cédric Le Goater clg at kaod.org
Mon Aug 28 16:36:30 AEST 2017


Hello,

> I don't see a corresponding change to pca955x_gpio_set_value(), though given
> it's hooked up as the gpiochip set() callback we would have to reimplement that
> interface. We should do that and return the error code rather than swallow it.
> This flows on to pca955x_gpio_direction_input() and
> pca955x_gpio_direction_output() where we currently just blindly return 0.

yes. Let's do it right. Sending a v2.
 
> I think that's it though, looks good otherwise
Thanks,

C. 


More information about the openbmc mailing list