[PATCH linux dev-4.10 v3 1/5] drivers/hwmon/pmbus: Add IBM power supply hwmon driver

[Andrew Jeffery]

On Mon, 2017-08-07 at 15:11 +0930, Andrew Jeffery wrote:
> > 
> > > 
> > > > +
> > > > +static const struct i2c_device_id ibmps_id[] = {
> > > > > > > > > +       { "witherspoon", witherspoon },
> > > > > +       { }
> > > > 
> > > > +};
> > > > +MODULE_DEVICE_TABLE(i2c, ibmps_id);
> > > > +
> > > > +static const struct of_device_id ibmps_of_match[] = {
> > > > > > > > > +       { .compatible = "ibm,ibmps" },
> > > > > +       {}
> > > > 
> > > > +};
> > > > +MODULE_DEVICE_TABLE(of, p8_i2c_occ_of_match);
> > > 
> > > p8_i2c_occ_of_match isn't right. Do we need both device tables?
> > > "witherspoon" as a device ID also seems unusual. What's going on there?
> > 
> > Uhh, not sure how that got in there... How does this compile?? I'll fix 
> > it. The power supply doesn't have any device id or anything, so I just 
> > went with witherspoon...
> 
> My issue is "withersoon" identifies a class of machine, not a power
> supply, even if the powersupply is specific to Witherspoon.

Further to this, I've just got hold of the datasheet. My reading of it
says the part number is "01KL054". Maybe the driver should include that
in its name and compatible.

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170808/e9541773/attachment.sig>