[PATCH v1] i2c: aspeed: fixed potential null pointer dereference

Joel Stanley joel at jms.id.au
Tue Aug 1 09:56:13 AEST 2017


[dropping upstream cc]

On Tue, Aug 1, 2017 at 3:50 AM, Brendan Higgins
<brendanhiggins at google.com> wrote:
> On Mon, Jul 31, 2017 at 2:27 AM, Joel Stanley <joel at jms.id.au> wrote:
>> On Sat, Jul 29, 2017 at 10:30 AM, Brendan Higgins
>> <brendanhiggins at google.com> wrote:
>>> Before I skipped null checks when the master is in the STOP state; this
>>> fixes that.
>>>
>>> Signed-off-by: Brendan Higgins <brendanhiggins at google.com>
>>
>> Acked-by: Joel Stanley <joel at jms.id.au>
>>
>> Out of interest, was this found by code review, or did you hit this in testing?
>
> I am pretty sure we hit it in testing. Unfortunately, we had trouble reproducing
> it, but we did see a null pointer dereference.

Thanks. I've applied it to the openbmc dev-4.10 tree as well.

Cheers,

Joel


More information about the openbmc mailing list