[PATCH linux dev-4.7 0/3] drivers: fsi: sbefifo: Add in-kernel API

[Brad Bishop]

Thanks for the patch Eddie.


> On Apr 18, 2017, at 5:07 PM, Eddie James <eajames at linux.vnet.ibm.com> wrote:
> 
> From: "Edward A. James" <eajames at us.ibm.com>
> 
> This patchset provides an in-kernel API for the SBEFIFO driver and the first
> user, a driver to access the P9 OCC hardware. There are also some potential
> devicetree bindings for the SBEFIFO and OCC devices.
> 
> The OCC provides a read/write interface, but only performs a single, atomic,
> OCC "command and response" operation per write operation. The driver cannot
> perform multiple writes in a row without first reading back to the user the
> response generated for each command. I can't see a use case for doing multiple
> commands without fetching the response.
> 
> Any feedback, particularly on how to improve the dt bindings or how to
> inform the OCC client that the SBEFIFO device has gone away (via unbinding
> FSI, or other means), would be helpful.
> 
> Edward A. James (3):

Since un-merged patches are needed for this to apply I think the normal thing
to do would have been for you and I to co-ordinate and one of us sent the
entire patchset (sbefifo + these three patches).

Lets do that when we re-submit for 4.10.

Anyone else, please don’t let this discourage you from providing cursory thoughts
especially on the DT bindings.

>  drivers: fsi: sbefifo: Add in-kernel API
>  drivers: fsi: sbefifo: Add OCC driver
>  ARM: dts: aspeed: witherspoon: Add example sbefifo and occfifo devices
> 
> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts |  16 +
> drivers/fsi/Kconfig                              |  10 +
> drivers/fsi/Makefile                             |   1 +
> drivers/fsi/fsi-sbefifo.c                        | 173 +++++-
> drivers/fsi/occfifo.c                            | 649 +++++++++++++++++++++++
> include/linux/fsi-sbefifo.h                      |  41 ++
> 6 files changed, 861 insertions(+), 29 deletions(-)
> create mode 100644 drivers/fsi/occfifo.c
> create mode 100644 include/linux/fsi-sbefifo.h
> 
> -- 
> 1.8.3.1