[PATCH v1 14/15] aspeed: Refactor SCU to use consistent mask & shift

Simon Glass sjg at chromium.org
Wed Apr 19 10:12:11 AEST 2017


On 17 April 2017 at 13:00, Maxim Sloyko <maxims at google.com> wrote:
> Refactor SCU header to use consistent Mask & Shift values.
> Now, consistently, to read value from SCU register, mask needs
> to be applied before shift.
>
> Signed-off-by: Maxim Sloyko <maxims at google.com>
> ---
>
> Changes in v1: None
>
>  arch/arm/include/asm/arch-aspeed/scu_ast2500.h | 12 ++++----
>  arch/arm/mach-aspeed/ast2500/sdram_ast2500.c   |  5 ++--
>  drivers/clk/aspeed/clk_ast2500.c               | 39 +++++++++++++-------------
>  3 files changed, 27 insertions(+), 29 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

OK, so ignore my earlier comment about shift/mask.


More information about the openbmc mailing list