Aspeed for-next pushed for 4.12

Rick Altherr raltherr at google.com
Sat Apr 8 01:51:56 AEST 2017


Changes look good.  Regarding AHB reset for the ADC to work, I also
see that 1e6e2004 has a bit to hold the ADC in reset.  I didn't do
anything in the ADC driver to take it out of reset.  Do we do that in
aspeed_init_early as well?

On Fri, Apr 7, 2017 at 3:28 AM, Joel Stanley <joel at jms.id.au> wrote:
> Here's a merge of the changes I will be sending to the arm maintainers for
> inclusion in 4.12.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git/log/?h=for-next
>
> I've done plenty of testing of this merged into linux-next. Feel free to
> take a look and/or use it in your testing.
>
> If you're booting this kernel from a cold power on, note that the ADC driver
> won't work without resetting the AHB bridge:
>
> devmem 0x1e6e200c 32 0x2
>
> On the dev- kernels we have a reset in the aspeed_init_early code path. We
> need to work out why that's the case, and add it to upstream if it's
> required.
>
> Cheers,
>
> Joel


More information about the openbmc mailing list