[PATCH 2/3] aspeed: Fixed FUC -> FUN typo in SCU.

[Maxim Sloyko]

Hi Joel,

Sorry for long delay, I got distracted by other projects that needed
immediate attention. I'll be sending new and updated patches soon.

On Mon, Oct 17, 2016 at 11:36 PM, Joel Stanley <joel at jms.id.au> wrote:

> On Tue, Oct 18, 2016 at 4:27 AM, Maxim Sloyko <maxims at google.com> wrote:
> >
> >
> > On Thu, Oct 13, 2016 at 5:07 PM, Joel Stanley <joel at jms.id.au> wrote:
> >>
> >> On Fri, Sep 30, 2016 at 7:27 AM,  <maxims at google.com> wrote:
> >> > From: Maxim Sloyko <maxims at google.com>
> >> >
> >> > Fixed FUC -> FUN typo in SCU.
> >>
> >> This lacks a signed off by as previously discussed.
> >>
> >> You have not made a convincing argument for this change. I suggest you
> >> drop the patch from your series.
> >
> >
> > Are you against this change per se or just against it being in this patch
> > series?
>
> In our tree at the moment.
>
> We're happy to take drivers that are on their way to being upstream,
> or fixes for bugs that we're hitting.
>
> Other than that our goal should be cleaning up the tree so we can
> submit it upstream. Once we submit upstream everyone has a common base
> to work from, which makes doing cleanups easier.
>

I still don't get it. Is this not a cleanup? I think having consistent
naming is important. It would be understandable if this file was already in
upstream tree and I would be touching parts that are in upstream version
and parts that aren't, but
this file only exists in our tree.

What is the downside?


>
> Cheers,
>
> Joel
>



-- 
*M*axim *S*loyko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161027/f88a2eae/attachment.html>