[PATCH linux 2/2] phy/broadcom: Add support for BCM54612E

[Joel Stanley]

On Fri, Oct 21, 2016 at 6:58 AM, Xo Wang <xow at google.com> wrote:
> Hi Joel,
>
> On Tue, Oct 18, 2016 at 8:49 PM, Joel Stanley <joel at jms.id.au> wrote:
>> Hello Xo,
>>
>> On Wed, Oct 19, 2016 at 12:28 PM, Xo Wang <xow at google.com> wrote:
>>> This PHY has internal delays enabled after reset. This clears the
>>> internal delay enables unless the interface specifically requests them.
>>
>> This looks fine to me. We have a similar patch for adding the Broadcom
>> phy on some of our machines. I just noticed that isn't present in
>> dev-4.7, as we were sorting out an issue that required us to force the
>> PHY into 100MBit mode. Would the aneg change be related to that?
>
> Exactly, this is just for a different PHY. I'm not sure about the
> BCM54210E part that Firestone uses. The Broadcom docs for our part's
> internal delay says that it increases with decreasing link speed (1.9
> ns, 4 ns, 50
> ns for 1000 M, 100 M, 10 M, respectively) so it broke for me at all speeds.

Ok. I will add it to the backlog to investigate this. Thanks for the
explanation.

>>
>> I suggest you submit these two one upstream. Use
>> scripts/get_maintainer.pl to work out what mailing list to send it to.
>> CC me so I can provide my ack.
>>
>
> Will do, thanks.

I added the patches to dev-4.7 so that you can move forward. I usually
prefer to wait for upstream and backport that version, but I can't see
upstream asking you to make many changes.

Cheers,

Joel