[PATCH 4.4 9/9] net/ncsi: Improve HNCDSC AEN handler
Gavin Shan
gwshan at linux.vnet.ibm.com
Fri Oct 21 11:47:46 AEDT 2016
This improves AEN handler for Host Network Controller Driver Status
Change (HNCDSC):
* The channel's lock should be hold when accessing its state.
* Do failover when host driver isn't ready.
* Configure channel when host driver becomes ready.
NOTE: The first one isn't applied to the code in dev-4.4.
Signed-off-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
---
net/ncsi/ncsi-aen.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c
index 5bc0873..26ac93d 100644
--- a/net/ncsi/ncsi-aen.c
+++ b/net/ncsi/ncsi-aen.c
@@ -142,8 +142,7 @@ static int ncsi_aen_handler_hncdsc(struct ncsi_dev_priv *ndp,
ncm = &nc->nc_modes[NCSI_MODE_LINK];
hncdsc = (struct ncsi_aen_hncdsc_pkt *)h;
ncm->ncm_data[3] = ntohl(hncdsc->status);
- if (ndp->ndp_active_channel != nc ||
- ncm->ncm_data[3] & 0x1)
+ if (ndp->ndp_active_channel != nc)
return 0;
/* If this channel is the active one and the link doesn't
@@ -151,7 +150,8 @@ static int ncsi_aen_handler_hncdsc(struct ncsi_dev_priv *ndp,
* The logic here is exactly similar to what we do when link
* is down on the active channel.
*/
- ndp->ndp_flags |= NCSI_DEV_PRIV_FLAG_CHANGE_ACTIVE;
+ if (!(ncm->ncm_data[3] & 0x1))
+ ndp->ndp_flags |= NCSI_DEV_PRIV_FLAG_CHANGE_ACTIVE;
ncsi_suspend_dev(nd);
return 0;
--
2.1.0
More information about the openbmc
mailing list