[PATCH linux v5 13/18] drivers/fsi: Set up links for slave communication

Christopher Bostic christopher.lee.bostic at gmail.com
Fri Oct 21 01:16:13 AEDT 2016


On Wed, Oct 19, 2016 at 7:10 PM, Joel Stanley <joel at jms.id.au> wrote:
> Hey Chris,
>
> On Thu, Oct 20, 2016 at 10:09 AM, Jeremy Kerr <jk at ozlabs.org> wrote:
>>> Enable each link and send a break command in preparation
>>> for scanning each link for slaves.
>>
>> Looks good!
>>
>> Acked-by: Jeremy Kerr <jk at ozlabs.org>
>
> Woot! Your first ack. This is a great milestone. Congratulations to
> you and Jeremy for your persistence in getting to this point.
>
> You can add the ack to the commit message of this patch (providing you
> don't change the code again).
>

Hi Joel,

The only thing I'd need to do is modify the commit message to relocate the
version history log.  Would that prevent me from adding an ack at this
point?

> I was wondering, is this good to go on hardware? If so, I will fire up
> a palmetto and give it a spin.
>

This code as it exists in the patch set hasn't been fully tested.  I'm
in process
of doing that now.

Thanks,
Chris

> Cheers,
>
> Joel


More information about the openbmc mailing list