[PATCH linux v5 14/18] drivers/fsi: Set slave SMODE to init communications
Jeremy Kerr
jk at ozlabs.org
Thu Oct 20 11:24:44 AEDT 2016
Hi Chris,
> Set CFAM to appropriate ID so that the controlling master
> can manage link memory ranges. Add slave engine register
> definitions.
Looks good, one minor thing:
> @@ -329,6 +400,17 @@ static int fsi_master_scan(struct fsi_master *master)
> "Break to link:%d failed with:%d\n", link, rc);
> continue;
> }
> + /* Verify can read slave at default ID location. If fails */
> + /* then there must be nothing on other end of link */
Best to do this in a single comment. However, don't do a v6 just for
this, as it's really insignificant. Only re-roll this patch if there are
other changes required.
Acked-by: Jeremy Kerr <jk at ozlabs.org>
Cheers,
Jeremy
More information about the openbmc
mailing list