[PATCH linux dev-4.7 12/12] mtd: spi-nor: aspeed: use fast read when doing DMAs

[Cédric Le Goater]

On 10/17/2016 11:10 AM, Joel Stanley wrote:
> On Mon, Oct 17, 2016 at 5:12 PM, Cédric Le Goater <clg at kaod.org> wrote:
>> Hello Joel,
>>
>> On 10/17/2016 07:04 AM, Joel Stanley wrote:
>>> On Fri, Oct 14, 2016 at 11:08 PM, Cédric Le Goater <clg at kaod.org> wrote:
>>>> Try to improve the speed of transfers when doing DMAs
>>>
>>> This could get squashed into the DMA adding patch I think.
>>
>> If you haven't pushed yet, you can drop this one, it does not
>> change anything in fact.
>>
>> I am currently looking at introducing some timing support
>> to speed up reading on the SPI, like pflash does and I am
>> shuffling the code quite a lot to isolate the different settings.
>>
>>
>> Just to say they are more changes to come to cleanup the driver.
> 
> Okay, great.
> 
> I will hold off merging the patches for a little white. We will need
> to commit them some time this week though. If they are not the final
> version then that is okay.

I am tired of the little fixes so I will make one big patch for the 
aspeed smc, AST2400 and AST2500, then a couple more for the dts, plus 
one for the dma (as I am not sure it is useful). I have another one 
pending for timing optimizations but that is too drafty for the moment.

Hopefully, I can make the patchset common with mainline with a first 
revert of what we have today in openbmc and some API fixes for 4.8.

> Once you have something ready for upstream, we should cc Ben H (who 
> as you know wrote pflash) for his thoughts. We need to do that this 
> week as he won't have much time next week.

Sure. I have questions on the default settings. Some are strapped 
by hardware, like the Div 2, depending on the controller type, some 
are not but we would like that to work in all cases. I have started 
to maintain a static table per chip jedec for these in the driver. 
I am not sure of the approach, but first, let's get a clean common 
base to work with.

Thanks,

C.