[PATCH 3/3] aspeed/g5: I2C driver.

[Maxim Sloyko]

On Mon, Oct 10, 2016 at 12:19 AM, Joel Stanley <joel at jms.id.au> wrote:

> On Tue, Oct 4, 2016 at 7:41 AM, Maxim Sloyko <maxims at google.com> wrote:
> >> > +
> >> > +static const struct udevice_id ast_i2c_ids[] = {
> >> > +       {.compatible = "aspeed,ast2400-i2c-controller",},
> >> > +       {.compatible = "aspeed,ast2400-i2c-bus",},
> >>
> >> Your subject says g5, but your compatible strings say g4.
> >>
> >> Your probe function doesn't test for which string you're using. Why do
> >> you have both -controller and -bus?
> >
> >
> > I think this has something to do with how the device tree is processed,
> but
> > it seems that because i2c buses are specified under a single controller
> > node, if I don't specify compatibility with -controller, it does not
> match
> > -bus nodes.
>
> I don't follow?
>
> The hardware has a few registers that are common across many busses.
> The device tree describes them in the controller node, with the buses
> being children of this node.
>
> Cheers,
>
> Joel
>

I don't use them in this driver. At least not directly.

What are you proposing?



-- 
*M*axim *S*loyko
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20161010/0df3335d/attachment.html>