[PATCH u-boot 00/12] config cleanups and small fixes

Cédric Le Goater clg at kaod.org
Mon Oct 10 17:57:55 AEDT 2016


On 10/10/2016 08:24 AM, Joel Stanley wrote:
> On Fri, Oct 7, 2016 at 6:24 PM, Cédric Le Goater <clg at kaod.org> wrote:
>> On 10/06/2016 11:26 PM, Cédric Le Goater wrote:
>>> Hello,
>>>
>>> Here is a set of cleanups on the configuration. It should ease the
>>> port on v2016.11 which is a little more strict on CONFIG_ defines.
> 
> Nice one! I had a look at all of the patches and they look good. 

The goal of the clean up is to reshuffle a bit our patches for upstreaming
and have a patchset organized like this:

  1 - core enablement G4 + G5 (minimal lowlevel init)
  2 - core enablement G4 + G5 (extra lowlevel init)
  3 - hacks patch (to fix)
  4 - ftgmac100 driver extensions patch
  5 - non ncsi platforms patch (should be only defconfigs files)
  6 - flash driver patch (needs a rewrite but there are works being done in
      that area in mainline)
  7 - aspeednic driver patch (should be deprecated  one day)
  8 - ncsi platforms patch (should be only defconfigs files)

So this is very close to what we have today and the work is mostly on the 
configuration. 

I am not sure about the 1-2 split. This is currently well contained in one
routine so it might be better to keep as it is. It would be easier to update 
also with Aspeed modifications.


> I will hold off on the last two relating to ramdisk until we see what
> upstream say.

yes. I am not sure where we stand on this. 

Uboot code is a bit fuzzy in that area as it seems that legacy images 
and ATAGS boot are not the most common path. What I found curious is 
that the load address of the ram disk image is not used at all. I hope 
the maintainers will clarify a bit what should be done. It should be a 
"simple".

>> You will need this patch to start with :
>>
>>         https://github.com/legoater/u-boot/commit/d76a5e74286cd903c4eb96c3b5f762672121b02a
>>
>> forgot to send it :/
> 
> No worries, I will include it.

Thanks,
C. 



More information about the openbmc mailing list